This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix incorrect VNC information#4272
Merged
Merged
Conversation
ocket8888
added
bug
ocket8888
approved these changes
Jan 9, 2020
ocket8888
left a comment
ocket8888
left a comment
Contributor
There was a problem hiding this comment.
Builds without error or warning, looks fine, accurate to the actual exposed port
zrhoffman
reviewed
Jan 10, 2020
| alias mydc="docker-compose -f $PWD/docker-compose.yml -f $PWD/optional/docker-compose.vnc.yml" | ||
| alias mydc="docker-compose "` \ | ||
| `"-f $PWD/docker-compose.yml "` \ | ||
| `"-f $PWD/docker-compose.expose-ports.yml "` \ |
Member
There was a problem hiding this comment.
docker-compose.expose-ports.yml is not necessary for VNC.
Contributor
There was a problem hiding this comment.
How would you access the VNC service if the port is kept internal to the Docker network?
Contributor
There was a problem hiding this comment.
oh, you mean you don't need expose the other ports. Yeah, I guess that's true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Build docs and confirm vnc connection works using CIAB
If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR
Additional Information